Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure MODS data is indexed when media object is indexed #5085

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Ensure MODS data is indexed when media object is indexed #5085

merged 2 commits into from
Mar 1, 2023

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Mar 1, 2023

Fixes #5073

For some reason descMetadata#to_solr was only being called and included in the parent media object's solr document if it had already been loaded. For example:

media_object = MediaObject.find(id)
media_object.to_solr["title_tesi"] # nil
#
media_object = MediaObject.find(id)
media_object.title # "Moomin"
media_object.to_solr["title_tesi"] # "Moomin"

Also included in this PR is a bugfix I found locally having to do with a modification of a frozen string.

masaball
masaball approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cjcolvar cjcolvar merged commit 7696f56 into develop Mar 1, 2023
@cjcolvar cjcolvar deleted the indexing_not_indexing branch March 1, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcolvar @masaball