Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MediaObject methods for improving save performance #5053

Merged
merged 12 commits into from
Feb 17, 2023

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Feb 7, 2023

No description provided.

@cjcolvar cjcolvar marked this pull request as ready for review February 7, 2023 16:32
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is still a failing test in the MediaObjectsController spec, but once that's taken care of I think we're good to go. This is looking great.

masaball
masaball previously approved these changes Feb 10, 2023
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cjcolvar cjcolvar force-pushed the mo_to_solr_refactor branch from efd1820 to 2e28876 Compare February 17, 2023 21:18
@cjcolvar cjcolvar merged commit 9180b03 into develop Feb 17, 2023
@cjcolvar cjcolvar deleted the mo_to_solr_refactor branch February 17, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants