Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change restricted redirect param to user_return_to #5003

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Change restricted redirect param to user_return_to #5003

merged 2 commits into from
Dec 6, 2022

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Dec 6, 2022

No description provided.

cjcolvar
cjcolvar reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'm wondering if it is possible to remove the usage of previous_url on line 79 of ApplicationController.

@masaball
Copy link
Contributor Author

masaball commented Dec 6, 2022 •
edited
Loading

My hesitation there was that at line 64 session[:previous_url] is still generated for, I think, the login popup that you would get from an embedded item. So for that specific case, it might still be necessary to have the session.delete(:previous_url). I may be being overly cautious.

@cjcolvar
Copy link
Member

cjcolvar commented Dec 6, 2022

You're totally right. I forgot about that scenario.

cjcolvar
cjcolvar previously approved these changes Dec 6, 2022
View reviewed changes
@masaball masaball merged commit 79102a4 into develop Dec 6, 2022
@masaball masaball deleted the redirect_params branch December 6, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masaball @cjcolvar