Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class instead of id since the id wasn't unique #5002

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Dec 6, 2022

With multiple files associated with a media object attempting to move any files after the first would cause the form target url be for the media object instead of the file leading to a 500 ("ActiveFedora::ModelMismatch (Expected MasterFile. Got: MediaObject)")

Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cjcolvar cjcolvar merged commit bd502d6 into develop Dec 6, 2022
@cjcolvar cjcolvar deleted the i_like_to_move_it branch December 6, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants