Remove "Item Unavailable" message from Checkouts table #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not necessary for there to be a message in the last column for items that are checked out.
cjcolvar
reviewed
Dec 2, 2022
Comment on lines
138
to
139
| elsif checkout.return_time < DateTime.current && checkout.media_object.lending_status == 'available' | ||
| view_context.link_to('Checkout', checkouts_url(params: { checkout: { media_object_id: checkout.media_object_id } }), class: 'btn btn-primary btn-xs', method: :post) |
There was a problem hiding this comment.
Should this case be removed as well to match the change in index.html.erb?
There was a problem hiding this comment.
Good question. @joncameron, If an item is not checked out should there be a checkout button next to the historical checkouts or should there only be Return buttons for current checkouts being rendered in the last column?
It will probably be cleaner and more consistent to have all historical checkouts blank, and a user can just use the link to the item page to try to check something out again.
There was a problem hiding this comment.
@masaball I agree, it would be better to have all historical checkouts blank. Let's go that route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4983