Properly handle case when master file has been deleted #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r file and derivatives on disk Flipping this flag for derivatives should resolve issue where derivative files would get deleted when a thumbnail is generated after initial master file processing
88ea0d8 to
f957f2e
Compare
cjcolvar
commented
Nov 11, 2022
| source = FileLocator.new(self.derivatives.where(quality_ssi: 'high').first.absolute_location) | ||
| options[:master] = false | ||
| options[:non_temp_file] = true |
There was a problem hiding this comment.
I think this is the key change for keeping derivative files from getting deleted by the unlinking on line 639. I changed the key to better reflect the expectations around this.
doug-hahn
added a commit
to TAMULib/avalon
that referenced
this pull request
Nov 14, 2022
Properly handle case when master file has been deleted avalonmediasystem#4932
doug-hahn
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4931
Related: #3475