Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change check out button text on item page #4865

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Change check out button text on item page #4865

merged 2 commits into from
Aug 31, 2022

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Aug 31, 2022

Change check out button text to Borrow for #{lending_period};
Screenshot from 2022-08-31 14-46-39

cjcolvar
cjcolvar previously approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I had a small code style suggestion but it isn't a blocker.

@Dananji @cjcolvar
Update spec/features/media_object_spec.rb
1694919 
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
@cjcolvar cjcolvar merged commit 86b0149 into develop Aug 31, 2022
@cjcolvar cjcolvar deleted the checkout-btn-text branch August 31, 2022 20:27
@cjcolvar cjcolvar mentioned this pull request Nov 29, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar