Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix html encoded titles in collection cards #4859

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Fix html encoded titles in collection cards #4859

merged 1 commit into from
Aug 29, 2022

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Aug 29, 2022

Before:
Screenshot from 2022-08-29 12-58-52
After:
Screenshot from 2022-08-29 12-59-10

The fix in this PR, removes string truncation from the JS code, and uses CSS's line-clamp property to limit the title to 2 lines along with other CSS properties truncates the overflowing text.

cjcolvar
cjcolvar approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Do you think something similar could be done for the metadata properties on the card?

@cjcolvar cjcolvar merged commit 65b14ed into develop Aug 29, 2022
@cjcolvar cjcolvar deleted the collection-card-title branch August 29, 2022 20:28
@Dananji
Copy link
Contributor Author

Dananji commented Aug 29, 2022

Yes, we could 👍 I'll check that out.

@cjcolvar cjcolvar mentioned this pull request Nov 29, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar