Improve devise error display #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaball
commented
Aug 29, 2022
cjcolvar
reviewed
Aug 29, 2022
There was a problem hiding this comment.
Good sleuthing! I wonder if there isn't a simpler solution though leaning into bootstrap_form and newer versions of files from devise. Would you be open to trying that out? It seems like you have a really good grasp on the situation so hopefully it wouldn't take too much time to try.
|
Yeah, I can try out those options. At the very least, definitely in our best interests to take care of the stuff being deprecated while I'm already working on them. Keep on top of some of the tech debt. |
Devise is deprecating the old helper method for displaying errors.
e956b9d to
75151b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the generation of sign up and related devise registration errors to provide details on what caused the error. It also removes extra white space between the label and entry field that was being added when errors triggered.