Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDL check to Stream token assignment #4839

Merged
merged 8 commits into from
Aug 26, 2022
Merged

Add CDL check to Stream token assignment #4839

merged 8 commits into from
Aug 26, 2022

Conversation

masaball
Copy link
Contributor

No description provided.

masaball and others added 6 commits August 22, 2022 14:35
Missed a change that I had made when originally implementing the new StreamToken logic in the service level rather than helper level. Reverting to the original spec.
I had removed an error catch for some testing and accidentally left it out
of the prior commit
@masaball masaball marked this pull request as ready for review August 23, 2022 13:16
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. One suggestion but if it doesn't make sense then I'm happy to merge as-is.

@cjcolvar cjcolvar merged commit b8cb3b0 into develop Aug 26, 2022
@cjcolvar cjcolvar deleted the cdl_stream_token branch August 26, 2022 15:45
@cjcolvar cjcolvar mentioned this pull request Nov 29, 2022
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants