Add CDL conditional logic #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaball
commented
Aug 8, 2022
masaball
commented
Aug 8, 2022
cjcolvar
reviewed
Aug 10, 2022
07beb7d to
9099434
Compare
Controlled digital lending needs to be able to be turned on and off. This adds conditional checks to routes, controllers, views, etc. to enable on/off functionality.
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
9099434 to
f2ec65f
Compare
cjcolvar
approved these changes
Aug 12, 2022
| @@ -314,7 +316,7 @@ def build_default_lending_period(collection) | |||
| d.negative? ? collection.errors.add(:lending_period, "days needs to be a positive integer.") : lending_period += d.days | |||
| h.negative? ? collection.errors.add(:lending_period, "hours needs to be a positive integer.") : lending_period += h.hours | |||
|
|
|||
| flash[:error] = collection.errors.full_messages.join if collection.errors.present? | |||
| flash[:error] = collection.errors.full_messages.join(' ') if collection.errors.present? | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.