Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to item page CDL controls #4818

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Updates to item page CDL controls #4818

merged 2 commits into from
Aug 5, 2022

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Aug 4, 2022

New checkout button styling:
checkout

When hovered over the checkout button, the text changes as follows;
borrow

@Dananji Dananji marked this pull request as draft August 5, 2022 13:09
<%= f.submit "Check Out", class: "btn btn-info check-out-btn",
data: { lending_period: ActiveSupport::Duration.build(@media_object.lending_period).to_day_hour_s } %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this from @masaball's code 🎉 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 I was about to comment that this would be a lot easier.

@Dananji Dananji marked this pull request as ready for review August 5, 2022 14:11
@Dananji Dananji force-pushed the cdl_item-page-updates branch from 9cd0445 to 6346b17 Compare August 5, 2022 14:14
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dananji Dananji merged commit 1bd4791 into develop Aug 5, 2022
@Dananji Dananji deleted the cdl_item-page-updates branch August 5, 2022 15:07
@cjcolvar cjcolvar mentioned this pull request Nov 29, 2022
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants