Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carry forward the set volume from a section to next section #4156

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Carry forward the set volume from a section to next section #4156

merged 2 commits into from
Jun 4, 2020

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Jun 2, 2020

No description provided.

@Dananji Dananji force-pushed the mejs-volume-fix branch from ebd67a6 to 0307f90 Compare June 3, 2020 13:53
@Dananji Dananji marked this pull request as ready for review June 3, 2020 13:56
@Dananji Dananji changed the title [WIP] Carry forward the set volume from a section to next section Carry forward the set volume from a section to next section Jun 3, 2020
cjcolvar
cjcolvar reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain the override changes you made in mediaelement and why they were necessary (so we can have a history of our modifications of ME.js for the next time we upgrade)?

cjcolvar
cjcolvar approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjcolvar cjcolvar merged commit 645fbd6 into develop Jun 4, 2020
@cjcolvar cjcolvar deleted the mejs-volume-fix branch June 4, 2020 16:17
@joncameron joncameron mentioned this pull request Jun 9, 2020
Closed
22 tasks
@Dananji Dananji mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar