ME.js player keyboard support #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53a34ee to
7de5c97
Compare
…eyboard actions when player is on page
7de5c97 to
76a52c4
Compare
cjcolvar
reviewed
Jun 1, 2020
| @@ -26,7 +26,7 @@ Unless required by applicable law or agreed to in writing, software distributed | |||
| <!-- Missing title and logo features --> | |||
| var mejs4AvalonPlayer = new MEJSPlayer({ | |||
| currentStreamInfo: <%= section_info.to_json.html_safe %>, | |||
| features: ['playpause', 'current', 'progress', 'duration', 'volume', 'tracks', <%= quality_feature.html_safe %>'linkBack', 'fullscreen'], | |||
| features: ['playpause', 'skipback', 'jumpforward', 'current', 'progress', 'duration', 'volume', 'tracks', <%= quality_feature.html_safe %>'linkBack', 'fullscreen'], | |||
There was a problem hiding this comment.
I wonder if we really want this in the embed player since we have limited space within the iframe, but it would be helpful in fullscreen mode and it might have to be in the normal size in order to be in fullscreen. What do other people think?
@joncameron
There was a problem hiding this comment.
I feel like this might be too much and cramp the rail even further. But I'm interested in at least testing it out on Spruce and feel it out. Maybe these could also sit outside of the MEjs features row.
cjcolvar
approved these changes
Jun 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following;
fkey will make the player enter/exit fullscreen, etc.