Skip waveform generation if no audio track #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
May 22, 2020
There was a problem hiding this comment.
I think I may have given bad advice. Looking at this again, we need to handle the case when a master file doesn't have any derivatives. Using master_file.derivatives.any?(&:audio_codec) would handle this case and might be nicer than using the safe navigator: master_file.derivatives.first&.audio_codec.present?. A test should probably be added for this case.
3f00dea to
3f0b276
Compare
Co-authored-by: cjcolvar <cjcolvar@indiana.edu>
3f0b276 to
efc41d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: cjcolvar cjcolvar@indiana.edu