Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard rdf predicates #4112

Merged
merged 2 commits into from
May 7, 2020
Merged

Use standard rdf predicates #4112

merged 2 commits into from
May 7, 2020

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented May 5, 2020

Also make website label optional and use plain text fields because built in validations of email and url cause odd behaviors with the modal.

phuongdh
phuongdh approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@phuongdh phuongdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjcolvar cjcolvar merged commit aebddfc into develop May 7, 2020
@cjcolvar cjcolvar deleted the rdf_predicates branch May 7, 2020 19:54
@joncameron joncameron mentioned this pull request Jun 9, 2020
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phuongdh phuongdh phuongdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcolvar @phuongdh