Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fetch Derivative.absolute_location in WaveformJob #4088

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Attempt to fetch Derivative.absolute_location in WaveformJob #4088

merged 2 commits into from
Apr 23, 2020

Conversation

phuongdh
Copy link
Member

@phuongdh phuongdh commented Apr 21, 2020 •
edited
Loading

To avoid pulling from the streaming server if possible.

cjcolvar
cjcolvar reviewed Apr 22, 2020
View reviewed changes
cjcolvar
cjcolvar reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Could you please add a test like the on disk and not on disk contexts?

cjcolvar
cjcolvar approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjcolvar cjcolvar merged commit 001cc86 into develop Apr 23, 2020
@cjcolvar cjcolvar deleted the waveform-improv branch April 23, 2020 20:29
@joncameron joncameron mentioned this pull request Jun 9, 2020
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phuongdh @cjcolvar