Supplemental file storage #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: phuongdh <phuongdh@gmail.com>
33b3020 to
7f19808
Compare
Co-authored-by: phuongdh <phuongdh@gmail.com>
phuongdh
approved these changes
Apr 20, 2020
|
After the upgrade of aws-sdk there was one failing test. The issue was that aws-s3-sdk was subverting FakeFS when doing download_file so the file didn’t exist in the FakeFS filesystem but it did in the real filesystem. Switching to Tempfile felt better in the real code and allowed for getting rid of FakeFS in the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ActiveStorage to allow for avalon to be configured to store files on disk or in s3 (or other cloud storage).