Supplemental file add/remove UI #4080
Conversation
Dananji
commented
Apr 9, 2020
•
| @@ -211,6 +255,13 @@ Unless required by applicable law or agreed to in writing, software distributed | |||
| $('#' + target).toggleClass('hidden'); | |||
| }); | |||
|
|
|||
| $('.files_toggle').on('click', function (e) { | |||
There was a problem hiding this comment.
Should this one line be unindented? It looks odd as it is right now.
app/assets/stylesheets/avalon.scss
Outdated
| div.transcript_file_view { | ||
| display: flex; | ||
| } |
There was a problem hiding this comment.
It doesn't look like this is used. Can it be removed?
| inputField.focus(); | ||
| }); | ||
|
|
||
| $('button[name="label_edit_cancel"]').on('click', e => { |
There was a problem hiding this comment.
For consistency would it make sense to rename this button cancel_edit_label?
| // Page reload to show the flash message | ||
| location.reload(); |
There was a problem hiding this comment.
I wonder if it is really necessary to reload the page for a label update. Maybe an inline indication of success would be better? But I'd wait on feedback from PO before changing this since it looks like it already works.
There was a problem hiding this comment.
Yeah, that sounds good to me. Now that I think about it, some inline edit forms do not have feedback flash messages (e.g. editing markers in playlists, add to playlist in item page. these are the inline forms I can think of right now).
Yes I agree 💯 |