Update rails to 5.2.4.2 for actionview XSS fix #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
previously approved these changes
Mar 24, 2020
| @@ -68,6 +68,10 @@ COPY --from=download /usr/bin/ff* /usr/bin/ | |||
|
|
|||
| # Build devevelopment image | |||
| FROM base as dev | |||
| RUN apt-get install -y --no-install-recommends --allow-unauthenticated \ | |||
There was a problem hiding this comment.
Was this just missed before or needed as part of this upgrade?
There was a problem hiding this comment.
This is needed now because I couldn't update Rails without installing nokogiri, which requires build dependencies.
fc20c99 to
2e8f72c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.