Add production stage to Dockerfile #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d6af90 to
a3cf926
Compare
cjcolvar
reviewed
Mar 23, 2020
| && curl -L https://github.com/jwilder/dockerize/releases/download/v0.6.1/dockerize-linux-amd64-v0.6.1.tar.gz | tar xvz -C /usr/bin/ \ | ||
| && mkdir -p /tmp/ffmpeg && cd /tmp/ffmpeg \ | ||
| && chmod +x /usr/local/bin/chromedriver | ||
| RUN curl https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -o /chrome.deb |
There was a problem hiding this comment.
Is this installed later or only downloaded?
cjcolvar
reviewed
Mar 23, 2020
Dockerfile
Outdated
| # Dev stage for building dev image | ||
| FROM ruby:2.5.5-slim-stretch as dev | ||
| # Base stage for building final images | ||
| FROM ruby:2.5.5-slim-stretch as base | ||
| ENV BUNDLER_VERSION 2.0.2 |
There was a problem hiding this comment.
Should this be generalized like: https://github.com/avalonmediasystem/avalon/pull/4053/files#diff-3254677a7917c6c01f55212f86c57fbfR16
cjcolvar
reviewed
Mar 23, 2020
Comment on lines
+67
to
+70
| if ENV["RAILS_LOG_TO_STDOUT"].present? | ||
| logger = ActiveSupport::Logger.new(STDOUT) | ||
| logger.formatter = config.log_formatter | ||
| config.logger = ActiveSupport::TaggedLogging.new(logger) |
cjcolvar
reviewed
Mar 23, 2020
Cutting down on layers only matters in the final image. For the supporting stages, I sometimes split them up to get granular caching (1 voided cache doesn't ruin others) |
a3cf926 to
29025dd
Compare
cjcolvar
approved these changes
Mar 23, 2020
phuongdh
added a commit
that referenced
this pull request
Jun 9, 2020
* Restructure Dockerfile, add prod stage * Add build target to docker-compose * Further slim down prod image * Allow logging to stdout in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.