Save hls_url if present #3972
Merged
Save hls_url if present #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line was removed from avalon 7 as part of the transcoding backend switch to newer active_encode with ffmpeg adapter instead of matterhorn. It is reinserted here to avoid breaking streaming of intercom pushed items that are not managed streams. In this case hls_url isn't being set and location_url is the rtmp url because setStreamingLocations isn't setting it because the derivative is unmanaged. In the end the item is not streamable since it doesn't have an HLS url and only an RTMP url. It would be good to switch to get rid of the need for two separate fields for RTMP and HLS streaming urls but it would require a larger refactoring of the code and possibly a data migration which probably isn't worth it at this stage.
phuongdh
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line was removed from avalon 7 as part of the transcoding backend
switch to newer active_encode with ffmpeg adapter instead of matterhorn.
It is reinserted here to avoid breaking streaming of intercom pushed
items that are not managed streams. In this case hls_url isn't being
set and location_url is the rtmp url because setStreamingLocations isn't
setting it because the derivative is unmanaged. In the end the item is
not streamable since it doesn't have an HLS url and only an RTMP url.
It would be good to switch to get rid of the need for two separate
fields for RTMP and HLS streaming urls but it would require a larger
refactoring of the code and possibly a data migration which probably
isn't worth it at this stage.
Fixes VOV-6113.