Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ActionMailer not using SES #3946

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Fix ActionMailer not using SES #3946

merged 1 commit into from
Jan 21, 2020

Conversation

phuongdh
Copy link
Member

@phuongdh phuongdh commented Jan 17, 2020 •
edited
Loading

Tested working on demobox

Fixes #3944

@cjcolvar
Copy link
Member

Is there any documentation changes that need to happen to explain the what the environment variable should look like?

cjcolvar
cjcolvar approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phuongdh
Copy link
Member Author

Is there any documentation changes that need to happen to explain the what the environment variable should look like?

Good point, I took the opportunity to update our config wiki https://wiki.dlib.indiana.edu/display/VarVideo/Configuration+Files

@phuongdh phuongdh merged commit ceeb588 into develop Jan 21, 2020
@phuongdh phuongdh deleted the actionmailer-ses branch January 21, 2020 14:33
@joncameron joncameron mentioned this pull request Feb 10, 2020
Closed
@cjcolvar cjcolvar mentioned this pull request Feb 27, 2020
Closed
@joncameron joncameron mentioned this pull request Feb 28, 2020
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phuongdh @cjcolvar