Allow intercom response to take an hour before timing out. #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Jan 13, 2020
There was a problem hiding this comment.
An hour is a long time do you think a smaller timeout would still work based upon what you were seeing when running the mass push? I'm just afraid of a scenario where many of these wait for timeout and end up using a lot of resources.
@bkeese and I talked about this and I think that the scenario I was envisioning is not likely and other scenarios are so an hour timeout seems fine to avoid having any long running items from being blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large intercom pushes can take awhile if the target server is busy. Wait longer than the default 60 seconds.