Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for video player not working with spacebar #3427

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Fix for video player not working with spacebar #3427

merged 1 commit into from
Jun 19, 2019

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Jun 18, 2019

@bkeese This is what I could work out to make the spacebar work with the video. Doing the inverse of what should be done within the eventHandler makes this work correctly with subsequent key presses.

@Dananji Dananji requested a review from bkeese June 18, 2019 13:29
bkeese
bkeese approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@bkeese bkeese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By my read, we stopped using the avalonmediasystem mediaelement gem in July 2017. So, this looks good to me.

@Dananji Dananji merged commit 10716a1 into develop Jun 19, 2019
@cjcolvar cjcolvar deleted the fix-play-pause-with-spacebar branch August 2, 2019 20:16
@Dananji Dananji mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeese bkeese bkeese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @bkeese