Merge pull request #4132 from avalonmediasystem/safe_constantize

Simplify and avoid error handling by using safe_constantize

app/models/master_file.rb

@@ -744,9 +744,8 @@ def update_ingest_batch
   end
 
   def find_encoder_class(klass_name)
-    return nil if klass_name.blank? || !Object.const_defined?(klass_name)
-    klass = Object.const_get(klass_name)
-    return klass if klass.ancestors.include?(ActiveEncode::Base)
+    klass = klass_name&.safe_constantize
+    klass if klass&.ancestors&.include?(ActiveEncode::Base)
   end
 
   def stop_processing!

app/presenters/speedy_af/proxy/master_file.rb

@@ -22,9 +22,8 @@ def encoder_class
   end
 
   def find_encoder_class(klass_name)
-    return nil if klass_name.blank? || !Object.const_defined?(klass_name)
-    klass = Object.const_get(klass_name)
-    return klass if klass.ancestors.include?(ActiveEncode::Base)
+    klass = klass_name&.safe_constantize
+    klass if klass&.ancestors&.include?(ActiveEncode::Base)
   end
 
   def display_title

spec/models/master_file_spec.rb

@@ -339,6 +339,11 @@
       expect(subject.encoder_class).to eq(WatchedEncode)
     end
 
+    it "should fall back to Watched when a workflow class can't be resolved" do
+      subject.encoder_classname = 'my-awesomeEncode'
+      expect(subject.encoder_class).to eq(WatchedEncode)
+    end
+
     it "should resolve an explicitly named encoder class" do
       stub_const("EncoderModule::MyEncoder", Class.new(ActiveEncode::Base))
       subject.encoder_classname = 'EncoderModule::MyEncoder'

spec/presenters/speedy_af/proxy/master_file_spec.rb

@@ -41,6 +41,13 @@
         end
       end
 
+      context 'with invalid class name' do
+        let(:master_file) { FactoryBot.create(:master_file, encoder_classname: 'my-awesomeEncode') }
+        it "should fall back to Watched when a workflow class can't be resolved" do
+          expect(subject.encoder_class).to eq(WatchedEncode)
+        end
+      end
+
       context 'with encoder class name' do
         let(:master_file) { FactoryBot.create(:master_file, encoder_classname: 'EncoderModule::MyEncoder') }
         it "should resolve an explicitly named encoder class" do