wip - Support compilation of "helper" modules #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: This needs to be smarter. | ||
| function shouldTranspile(filePath) { | ||
| return testDir === path.dirname(filePath) && filePath[0] === '_' || filePath === testPath; | ||
| } |
There was a problem hiding this comment.
This shouldTranspile definitely needs to be improved. Very naive.
I'm holding off investing time on it until we have a decision what the API and CLI should look like.
1e5d96d to
f1973b9
Compare
| } | ||
|
|
||
| // TODO: This needs to be smarter. | ||
| function shouldTranspile(filePath) { |
There was a problem hiding this comment.
This shouldTranspile method definitely needs to be improved. Very naive.
I'm holding off investing time on it until we have a decision what the API and CLI should look like.
8105b2b to
64e360c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the basic requirements of #156.
It relies on floatdrop/require-from-string#3
Along the way I uncovered a few other bugs that should get fixed in master (I will call those out in line comments).
// @floatdrop