Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a table of contents to readme.md #168

Closed
wants to merge 1 commit into from

Conversation

markthethomas
Copy link
Contributor

Thought adding a streamlined TOC might make getting to some of the elements that are further down in the readme a little easier for reference usage. I didn't include every header/section since it ended up being too long 👍

@@ -4,6 +4,15 @@

[![Build Status: Linux](https://travis-ci.org/sindresorhus/ava.svg?branch=master)](https://travis-ci.org/sindresorhus/ava) [![Build status: Windows](https://ci.appveyor.com/api/projects/status/igogxrcmhhm085co/branch/master?svg=true)](https://ci.appveyor.com/project/sindresorhus/ava/branch/master) [![Coverage Status](https://coveralls.io/repos/sindresorhus/ava/badge.svg?branch=master&service=github)](https://coveralls.io/github/sindresorhus/ava?branch=master) [![Join the chat](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/sindresorhus/ava?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)

Table of contents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the ## header style instead of underline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and Table of Contents

@sindresorhus
Copy link
Member

@sindresorhus
Copy link
Member

Good idea!

@markthethomas
Copy link
Contributor Author

Oo yes, now to learn how to amend my commit 👍 Thank you @sindresorhus!

@sindresorhus
Copy link
Member

@markthethomas You don't have to amend. You can just push new commits too. I usually squash commits and cleanup afterwards anyways ;)

@markthethomas
Copy link
Contributor Author

Sounds good! Need to learn though — I'm a solo dev where I work and don't get to use Git in these ways all that often (usually just me talking to me lol) :)

@sindresorhus
Copy link
Member

Open source is definitely the best way to learn to use Git ;)

@markthethomas
Copy link
Contributor Author

Yes indeed! I think I just rebased and squashed the PR correctly?

@markthethomas
Copy link
Contributor Author

wait no — left the old TOC in there. Fixing!

@sindresorhus
Copy link
Member

Btw, noticed that your created the PR from master. First rule of PRs is to never do it from master, since that makes it hard to create multiple PRs. Create a new branch for each PR you do. Master is for syncing with upstream.

@@ -6,6 +6,14 @@

Even though JavaScript is single-threaded, IO in Node.js can happen in parallel due to its async nature. AVA takes advantage of this and runs your tests concurrently, which is especially beneficial for IO heavy tests. In addition, test files are run in parallel as separate processes, giving you even better performance and a isolated environment for each test file. [Switching](https://github.com/sindresorhus/pageres/commit/663be15acb3dd2eb0f71b1956ef28c2cd3fdeed0) from Mocha to AVA in Pageres brought the test time down from 31 sec to 11 sec. Having tests run concurrently forces you to write atomic tests, meaning tests that don't depend on global state or the state of other tests, which is a great thing!

## Table of contents
* [Usage](#usage)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use - instead of * for the items

@markthethomas
Copy link
Contributor Author

Oh ok — thanks for letting me know! I'll abandon this and create a new branch

@sindresorhus
Copy link
Member

No, you can finish this one first.

Since you can't change the branch of an existing PR.

@markthethomas
Copy link
Contributor Author

👍 (thanks for your patience while I fumble & learn)

Thought adding a streamlined TOC might make getting to some of the elements that are further down in the readme a little easier. I didn't include every header/section since it ended up being too long

Conform to rest of Readme style; move below intro
@markthethomas
Copy link
Contributor Author

should be good to merge unless there's anything else that needs adding :)

@sindresorhus
Copy link
Member

I've commented about https://github.com/sindresorhus/ava/pull/168/files#r44228402 twice (*-), but I can fix it in the merge.

@markthethomas
Copy link
Contributor Author

Argh -- my bad

Mark

Sent from my iPhone

@markthethomas everywhere

On Nov 9, 2015, at 11:22 PM, Sindre Sorhus notifications@github.com wrote:

I've commented about https://github.com/sindresorhus/ava/pull/168/files#r44228402 twice (* → -), but I can fix it in the merge.


Reply to this email directly or view it on GitHub.

@sindresorhus
Copy link
Member

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants