Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warp/handlers: update duration greater than assertion to pass on windows #991

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

aaronbuchwald
Copy link
Collaborator

This PR updates an assertion on the amount of time spent serving a request from using a duration to int64 value to match the value reported by the metric.

This fixes an error when running on Windows migrating this code to Coreth: https://github.com/ava-labs/coreth/actions/runs/6852336438/job/18630638235?pr=387
Screenshot 2023-11-13 at 16 10 56

@aaronbuchwald aaronbuchwald marked this pull request as draft November 13, 2023 21:39
@aaronbuchwald aaronbuchwald self-assigned this Nov 15, 2023
@aaronbuchwald aaronbuchwald marked this pull request as ready for review November 15, 2023 20:40
@darioush darioush enabled auto-merge (squash) November 15, 2023 20:47
@darioush darioush merged commit 32514d6 into master Nov 16, 2023
8 checks passed
@darioush darioush deleted the warp-handler-duration-fix branch November 16, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants