warp: add details to accepted message log #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
approved these changes
Nov 2, 2023
ceyonur
approved these changes
Nov 6, 2023
| @@ -75,7 +75,7 @@ type AcceptContext struct { | |||
| // will not maintain backwards compatibility of this interface and your code should not | |||
| // rely on this. Designed for use only by precompiles that ship with subnet-evm. | |||
| type Accepter interface { | |||
| Accept(acceptCtx *AcceptContext, txHash common.Hash, logIndex int, topics []common.Hash, logData []byte) error | |||
| Accept(acceptCtx *AcceptContext, blockHash common.Hash, blockNumber uint64, txHash common.Hash, logIndex int, topics []common.Hash, logData []byte) error | |||
There was a problem hiding this comment.
I wish we could have imported types.Log but seems it is cyclic :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds more information to the log emitted when a block sending warp messages are accepted.
How this works
Passes through blockNumber, blockHash.
How this was tested
CI
How is this documented
N/A