Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreth sync: 0.12.4-rc.0 -> 0.12.7 #975

Merged
merged 18 commits into from
Nov 7, 2023
Merged

coreth sync: 0.12.4-rc.0 -> 0.12.7 #975

merged 18 commits into from
Nov 7, 2023

Conversation

darioush
Copy link
Collaborator

Why this should be merged

How this works

How this was tested

How is this documented

@darioush darioush marked this pull request as ready for review October 31, 2023 21:50
@ceyonur ceyonur mentioned this pull request Nov 2, 2023
Merged
ceyonur
ceyonur reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put up a PR for some nit changes

Also: Do we want to apply this to Coreth? #874

eth/filters/api.go Show resolved Hide resolved
eth/state_accessor.go Outdated Show resolved Hide resolved
ethclient/ethclient.go Show resolved Hide resolved
rpc/types.go Show resolved Hide resolved
ethclient/ethclient.go Show resolved Hide resolved
@ceyonur ceyonur added this to the v0.5.9 milestone Nov 2, 2023
@ceyonur ceyonur assigned ceyonur and darioush and unassigned ceyonur Nov 2, 2023
@ceyonur ceyonur linked an issue Nov 2, 2023 that may be closed by this pull request
Migrate Upstream Coreth Changes through v0.12.5 #856
Closed
aaronbuchwald
aaronbuchwald previously approved these changes Nov 3, 2023
View reviewed changes
eth/state_accessor.go Outdated Show resolved Hide resolved
ceyonur
ceyonur previously approved these changes Nov 7, 2023
View reviewed changes
aaronbuchwald
aaronbuchwald previously approved these changes Nov 7, 2023
View reviewed changes
@darioush darioush dismissed stale reviews from aaronbuchwald and ceyonur via 930d921 November 7, 2023 19:06
@aaronbuchwald aaronbuchwald merged commit 8beb366 into master Nov 7, 2023
@aaronbuchwald aaronbuchwald deleted the coreth-0.12.7 branch November 7, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbuchwald aaronbuchwald aaronbuchwald left review comments

@ceyonur ceyonur ceyonur left review comments

@anusha-ctrl anusha-ctrl Awaiting requested review from anusha-ctrl

Assignees

@darioush darioush

Labels
None yet
Projects
No open projects
EVM
Status: Done ✅
Milestone
v0.5.9
Development

Successfully merging this pull request may close these issues.

Migrate Upstream Coreth Changes through v0.12.5
3 participants
@darioush @ceyonur @aaronbuchwald