Replace old packers #857
Merged
Replace old packers #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* override network upgrades * genesis network upgrades defaults * fix conflicts * Update plugin/evm/vm.go
darioush
previously approved these changes
Sep 14, 2023
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
…into replace-old-packers
Closed
marun
previously approved these changes
Dec 11, 2023
aaronbuchwald
approved these changes
Dec 14, 2023
marun
approved these changes
Dec 15, 2023
darioush
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Initially we wrote our own Unpack/Pack methods and had a fixed length check for input bytes. In #487 we became aware that Solidity/JS libraries can add some extra padding bytes at the end of the input (input must still be multiple of 32).
This PR replaces our legacy Packers with ones from ABI package to provide a better support. Also we have removed
the input len check with the DUpgrade to support Solidity padding. But we still need to keep this check before DUpgrade for backwards compatibility.
Closes: #510 #487
Test branch #843
How this was tested
How is this documented
This makes the code on-par with recent Solidity docs.