add multiatch docker build to support arm #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
reviewed
Jan 6, 2025
qdm12
reviewed
Jan 6, 2025
Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
Co-authored-by: Quentin McGaw <quentin.mcgaw@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
qdm12
previously approved these changes
Jan 6, 2025
darioush
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds support to multiarch docker builds and adds support for arm64 docker releases.
How this works
This pull request includes significant updates to the Docker image publishing workflow, focusing on improving the build process and enabling multi-platform support. The most important changes include updating the workflow configuration, enhancing the build scripts, and removing redundant scripts.
Workflow and Configuration Updates:
.github/workflows/publish_docker.yml: Updated the workflow to useubuntu-latestand added steps for installingqemu, creating a multi-platform docker builder, and building/publishing images to DockerHub.Build Script Enhancements:
scripts/build_docker_image.sh: Added support for multi-arch image builds and conditional publishing based on environment variables. The script now usesdocker buildxfor improved build performance and multi-arch support. [1] [2]Removal of Redundant Scripts:
.github/workflows/publish_docker_image.sh: Removed the obsolete script as its functionality has been integrated into the updated workflow and build scripts.Minor Fixes:
.github/workflows/publish_docker.yml: Standardized the use of double quotes for consistency.How this was tested
CI
Need to be documented?
No
Need to update RELEASES.md?
No