move network upgrade code to file #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
previously approved these changes
Mar 28, 2024
params/network_upgrades.go
Outdated
| } | ||
|
|
||
| // SetMappedUpgrades sets the mapped upgrades (usually Avalanche > EVM upgrades) for the chain config. | ||
| func (c *ChainConfig) SetMappedUpgrades() { |
There was a problem hiding this comment.
nit: Should we call this SetEVMUpgrades() or SetEthUpgrades?
Should we move it to params/config_extra.go?
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
darioush
previously approved these changes
Mar 28, 2024
darioush
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Moves network upgrade code to it's own file.
Fixes the Durango timestamp = 0 issue in ava-labs/avalanchego#2877
How this works
0 timestamps now defaults to the network defaults
How this was tested
Locally tested
How is this documented