ci: Add shellcheck step to lint job
#1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cfb8e4 to
3e7d9b4
Compare
joshua-kim
previously approved these changes
Jan 24, 2024
ceyonur
reviewed
Jan 24, 2024
ceyonur
reviewed
Jan 24, 2024
Reverted changes to the named upstream tests and updated the new script to support ignoring those files. |
darioush
approved these changes
Jan 24, 2024
ceyonur
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#lintallthethings!
We lint code, why not shell scripts? In addition to simplifying the avoidance of common shell errors, the shellcheck wiki has lots of documentation for all the error types it checks for.
Testing
In addition to CI, local testing on arm64 linux and macos verified the logic for downloading and using a local (vs one in the path) shellcheck.
Related: AvalancheGo PR