Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WaitForResult #1002

Merged
merged 2 commits into from
Nov 24, 2023
Merged

add WaitForResult #1002

merged 2 commits into from
Nov 24, 2023

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Nov 18, 2023

Adds a helper method to remove duplicated code.

Copy link

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@darioush
Copy link
Collaborator

cc @joshua-kim : not sure if this cleanup applies to the networking code in avalanchego as well, thought I'd mention you here

@darioush darioush enabled auto-merge (squash) November 24, 2023 15:34
@joshua-kim
Copy link
Contributor

cc @joshua-kim : not sure if this cleanup applies to the networking code in avalanchego as well, thought I'd mention you here

It shouldn't, long term we will deprecate all this code to use the p2p.Client

@darioush darioush merged commit e23ab05 into master Nov 24, 2023
8 checks passed
@darioush darioush deleted the network-nits branch November 24, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants