Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(all): fix upstream typos (WIP) #108

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

docs(all): fix upstream typos (WIP) #108

wants to merge 4 commits into from

Conversation

qdm12
Copy link
Collaborator

@qdm12 qdm12 commented Jan 24, 2025

This is a pull request, opened here only to easily check changes, to keep track and group typo fixes in upstream geth code, in order to batch propose these to geth whenever we reach enough changes worth proposing.

@ARR4N
Copy link
Collaborator

ARR4N commented Jan 28, 2025

This is a pull request, opened here only to easily check changes, to keep track and group typo fixes in upstream geth code, in order to batch propose these to geth whenever we reach enough changes worth proposing.

SGTM

You may want to base it off master (i.e. the upstream default branch) instead of main to simplify things when it comes to opening an upstream PR.

@qdm12
Copy link
Collaborator Author

qdm12 commented Jan 29, 2025

Isn't the main branch more up to date with geth's current master branch though? 🤔

@qdm12 qdm12 changed the title Fix upstream typos (WIP) docs(all): fix upstream typos (WIP) Jan 29, 2025
@ARR4N
Copy link
Collaborator

ARR4N commented Jan 29, 2025

Isn't the main branch more up to date with geth's current master branch though? 🤔

Feel free to synchronise master whenever you want. But please triple check the branch when you do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants