chore(metrics/prometheus): add files needed for coreth and subnet-evm #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
So that coreth and subnet-evm can use the metrics package from libevm instead of defining/depending on their own local metrics package.
➡️ coreth PR using this branch
➡️ subnet-evm PR using this branch
Also fixes and refactoring.
How this works
metrics/prometheus/prometheus.libevm.go
containing extra (non conflicting) code needed for coreth and subnet-evmGatherer
renamed toNewGatherer
to exportgatherer
and return a concrete*Gatherer
type ("accept interfaces, return concrete types")metrics.ResettingTimer
switch caseRegistry
interface inmetrics/prometheus/interfaces.libevm.go
ptrTo
generic functionHow this was tested
CI passing here, in coreth's PR and subnet-evm's PR