-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geth update to v1.13.14 #633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 71d949ee86f32175ff647d684c85c2f61b11b977.
* avoid modifying the pointer * improve readability * prevent race in tail reading * improve repairTxIndexTail readability * use shared func
ceyonur
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM, left few comments.
I will put up another PR to change the tx indexer lookup limit flag.
* use p2p handler ID * use TransactionHistory flag instead of TxLookupLimit * fix config tests
ceyonur
approved these changes
Sep 8, 2024
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* rename to subnet-evm * merge * merge * UT adjustments * rename to coreth * rename to coreth * put race detector back * fixes * lint * lint * use avalanchego with timestamp in local genesis for e2e * remove TODO comments * reduce diffs with ARR4N's branch * update for enforcing gasTip * make txindexer more similar to upstream * unbuffer chan * update to use commit(true) * use TestOnlyAllowDuplicateBlocks * Revert "update to use commit(true)" This reverts commit 71d949ee86f32175ff647d684c85c2f61b11b977. * overflow in state_transition err * add http body limit flag (#1327) * Tail lock revisited (#1328) * avoid modifying the pointer * improve readability * prevent race in tail reading * improve repairTxIndexTail readability * use shared func * nits * undo diff * nit * Coreth geth v1.13.14 sync rw (ava-labs#647) * use p2p handler ID * use TransactionHistory flag instead of TxLookupLimit * fix config tests --------- Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Applies ava-labs/subnet-evm#1152 to coreth
How this works
Takes code from upstream
How this was tested
[X] CI
[ ] Running testnet / mainnet nodes