Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move AllowUnfinalizedQueries out of vm.Config #443

Merged
merged 6 commits into from
Jan 5, 2024
Merged

refactor: move AllowUnfinalizedQueries out of vm.Config #443

merged 6 commits into from
Jan 5, 2024

Conversation

darioush
Copy link
Collaborator

@darioush darioush commented Dec 28, 2023 •
edited
Loading

Why this should be merged

I don't think AllowUnfinalizedQueries belongs in core/vm.Config, since that is the interpreter configuration.

How this works

Moves AllowUnfinalizedQueries to the backend

How this was tested

CI

@darioush darioush marked this pull request as ready for review December 28, 2023 05:10
ceyonur
ceyonur reviewed Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit

@darioush darioush enabled auto-merge (squash) January 4, 2024 22:46
@darioush darioush merged commit bebdd56 into master Jan 5, 2024
8 checks passed
@darioush darioush deleted the refactor-allow-unfinalized branch January 5, 2024 19:40
@darioush darioush mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun marun approved these changes

@ceyonur ceyonur ceyonur approved these changes

@aaronbuchwald aaronbuchwald Awaiting requested review from aaronbuchwald

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darioush @marun @ceyonur