-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate warp backend from Subnet-EVM #387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
darioush
previously approved these changes
Nov 16, 2023
ceyonur
reviewed
Nov 17, 2023
ceyonur
reviewed
Nov 18, 2023
Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org> Signed-off-by: aaronbuchwald <aaron.buchwald56@gmail.com>
ceyonur
approved these changes
Nov 28, 2023
darioush
approved these changes
Nov 28, 2023
darioush
pushed a commit
that referenced
this pull request
Apr 25, 2024
* save progress * save progress * saving more progress * add more context * more comments * fix items * fix removal * passs config * add additional comment * move cache init * remove TODO * fix logs format * nits * insert into cache oldest first * make bounded buffer generic * cleanup FIFO cache * cleanup comments * simplify bounded buffer * fix `Last` * nits * more comment nits * fix min size of FIFOCache * add NoOpFIFOCache * move `FlattenLogs` to `types` * fix off by 1 * revert LastBloomIndex * fifo cache nits * simplify bounded buffer * move acceptedHeaderCache to headerchain * remove unnecessary comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR migrates the
warp/
package and required accompanying changes from Subnet-EVM into Coreth: https://github.com/ava-labs/subnet-evm/tree/v0.5.9/warpHow this was tested
Takes test coverage from the migrated package.