refactor: using slices.Contains to simplify the code #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturrez
approved these changes
Jan 13, 2025
|
@dashangcun thank you for your contribution. Please sign your commit |
Signed-off-by: dashangcun <907225865@qq.com>
Signed. Please review again. |
felipemadero
approved these changes
Jan 14, 2025
owenwahlgren
pushed a commit
that referenced
this pull request
Jan 23, 2025
Signed-off-by: dashangcun <907225865@qq.com> Co-authored-by: arturrez <56270896+arturrez@users.noreply.github.com> Co-authored-by: felipemadero <felipe.madero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.
How this works
How this was tested
How is this documented