Use local machine to join as validator on any L1 #2548

sukantoraymond · 2025-01-10T07:27:09Z

This PR enables using local machine to join any L1 (Proof of Stake) as a validator.

To join an L1 as validator, call avalanche node local start <clusterName> followed by avalanche node local validate <clusterName>. User will be prompted for RPC URL.

If has more than 1 node in it, all nodes will be added as validators of the specified L1

E2E test will be implemented once #2528 is resolved

Sample output

AVL-7H2W7V:avalanche-cli raymondsukanto$ ./bin/avalanche node local validate newValidatorNode
✔ Fuji Testnet
✔ Use stored key
✔ newTestKey
Enter the amount of token to stake for each validator: 10
What is the RPC endpoint?: http://192.168.1.39:9650/ext/bc/qnk6K3xv5ryk5VpPHLonp3yapgAEteF22nEeNeBCBpdBkBPDg/rpc
Validator's balance is used to pay for continuous fee to the P-Chain
When this Balance reaches 0, the validator will be considered inactive and will no longer participate in validating the L1
How many AVAX do you want to each validator to start with?: 0.1
How many AVAX do you want to each validator to start with?: 0.1
✔ Get address from an existing stored key (created from avalanche key create or avalanche key import)
✔ newTestKey
✔ Get address from an existing stored key (created from avalanche key create or avalanche key import)
✔ newTestKey
A private key is needed to pay for initialization of the validator's registration (Blockchain gas token).
✔ Get private key from an existing stored key (created from avalanche key create or avalanche key import)
✔ newTestKey

Adding validator NodeID-96NKYng5sFfEykL3nwUZwHgXNTcbYBcm7

==============================================
Initializing a validator registration with PoS validator manager
Using rpcURL: http://192.168.1.39:9650/ext/bc/qnk6K3xv5ryk5VpPHLonp3yapgAEteF22nEeNeBCBpdBkBPDg/rpc
NodeID: NodeID-96NKYng5sFfEykL3nwUZwHgXNTcbYBcm7 staking 10 tokens
==============================================
ValidationID: GmifrnPauqBYQVdF29vJX4f4HYKMADYSan1twVEjgZ4SMZu2H
RegisterL1ValidatorTx fee: 0.000093580 AVAX
RegisterL1ValidatorTx ID: 2WNZcJioetRtuHSWQJu3iqN9hrG15XryYf5JpyAVYZ9wmCRfgd
Waiting for P-Chain to update validator information ... 100% [===============]           

  NodeID: NodeID-96NKYng5sFfEykL3nwUZwHgXNTcbYBcm7
  Network: Fuji
  Weight: 10
  Balance: 0.10000 AVAX
✓ Validator successfully added to the L1


Adding validator NodeID-BTg5dyzPYfGQGZZjgG9MdMMrqG7XzwrWA

==============================================
Initializing a validator registration with PoS validator manager
Using rpcURL: http://192.168.1.39:9650/ext/bc/qnk6K3xv5ryk5VpPHLonp3yapgAEteF22nEeNeBCBpdBkBPDg/rpc
NodeID: NodeID-BTg5dyzPYfGQGZZjgG9MdMMrqG7XzwrWA staking 10 tokens
==============================================
ValidationID: K9FhqzbWNeWH7EEqToc39eqqXpUvYvNbjFPm5LGXfPyNNvmTn
RegisterL1ValidatorTx fee: 0.000093580 AVAX
RegisterL1ValidatorTx ID: 2VdyWu5JM9k8RaWHKjqUTr4uYvGm3diJF3uZS8nAgJph7kx4sV
Waiting for P-Chain to update validator information ... 100% [===============]           

  NodeID: NodeID-BTg5dyzPYfGQGZZjgG9MdMMrqG7XzwrWA
  Network: Fuji
  Weight: 10
  Balance: 0.10000 AVAX
✓ Validator successfully added to the L1

✓ All validators are successfully added to the L1

cmd/nodecmd/local.go

meaghanfitzgerald · 2025-01-10T16:58:14Z

Can you elaborate in the PR description how a user would accomplish this with the CLI? Is there a new command to import a new L1 configuration or add an active RPC endpoint as a known L1 network? How does this work exactly

sukantoraymond · 2025-01-14T11:04:15Z

cmd/blockchaincmd/deploy.go

@@ -1563,60 +1519,6 @@ func ConvertURIToPeers(uris []string) ([]info.Peer, error) {
 	return aggregatorPeers, nil
 }

-func GetAggregatorExtraPeers(


Moving these functions to blockchain pkg so that it can be re used across cmds

sukantoraymond · 2025-01-14T11:04:36Z

cmd/blockchaincmd/prompt_owners.go

@@ -289,46 +289,3 @@ func getThreshold(maxLen int) (uint32, error) {
 	}
 	return uint32(intTh), err
 }
-
-func getKeyForChangeOwner(network models.Network) (string, error) {


Moving these functions to blockchain pkg so that it can be re used across cmds

pkg/validatormanager/registration.go

cmd/nodecmd/local.go

pkg/blockchain/helper.go

pkg/validatormanager/registration.go

cmd/nodecmd/local.go

Signed-off-by: sukantoraymond <rsukanto@umich.edu>

cmd/nodecmd/local.go

sukantoraymond · 2025-01-17T13:32:42Z

#2561

felipemadero

LGTM

* use local machine to join as validator * fix lint * update validate function * local machine validate l1 * update command description * lint * lint * address comments * fix merge * address comments * enable more than 1 node in a cluster to validate * address comments * fix lint * fix lint --------- Signed-off-by: sukantoraymond <rsukanto@umich.edu>

use local machine to join as validator

98be86e

sukantoraymond requested a review from a team as a code owner January 10, 2025 07:27

sukantoraymond requested review from arturrez and meaghanfitzgerald January 10, 2025 07:27

sukantoraymond marked this pull request as draft January 10, 2025 07:27

Merge branch 'main' into local-add-validator

d57eb99

github-advanced-security bot found potential problems Jan 10, 2025

View reviewed changes

cmd/nodecmd/local.go Dismissed Show dismissed Hide dismissed

fix lint

8076e6a

meaghanfitzgerald added this to the L1 Validator Management milestone Jan 10, 2025

meaghanfitzgerald assigned sukantoraymond Jan 10, 2025

meaghanfitzgerald mentioned this pull request Jan 10, 2025

Support adding validators to remote L1s (Fuji) #2378

Closed

update validate function

830b1d2

sukantoraymond force-pushed the local-add-validator branch from ec0a639 to 830b1d2 Compare January 13, 2025 10:56

Merge branch 'main' into local-add-validator

e310ba7

sukantoraymond linked an issue Jan 13, 2025 that may be closed by this pull request

Support adding validators to remote L1s (Fuji) #2378

Closed

sukantoraymond added 3 commits January 14, 2025 17:56

local machine validate l1

d6793bf

update command description

4177a8e

Merge branch 'main' into local-add-validator

07e8310

sukantoraymond marked this pull request as ready for review January 14, 2025 11:03

sukantoraymond commented Jan 14, 2025

View reviewed changes

lint

04f5e35

sukantoraymond commented Jan 14, 2025

View reviewed changes

pkg/validatormanager/registration.go Outdated Show resolved Hide resolved

lint

ba9ad16

sukantoraymond commented Jan 14, 2025

View reviewed changes

cmd/nodecmd/local.go Outdated Show resolved Hide resolved

felipemadero reviewed Jan 14, 2025

View reviewed changes

sukantoraymond added 3 commits January 15, 2025 17:17

address comments

e0bbeec

Merge branch 'main' into local-add-validator

6976cdc

Signed-off-by: sukantoraymond <rsukanto@umich.edu>

fix merge

c43b351

sukantoraymond added 2 commits January 15, 2025 17:38

address comments

b61952a

enable more than 1 node in a cluster to validate

a7114e1

felipemadero reviewed Jan 16, 2025

View reviewed changes

cmd/nodecmd/local.go Outdated Show resolved Hide resolved

cmd/nodecmd/local.go Show resolved Hide resolved

felipemadero reviewed Jan 16, 2025

View reviewed changes

cmd/nodecmd/local.go Outdated Show resolved Hide resolved

felipemadero reviewed Jan 16, 2025

View reviewed changes

cmd/nodecmd/local.go Outdated Show resolved Hide resolved

address comments

a4b0408

sukantoraymond added 2 commits January 17, 2025 20:33

fix lint

7b4f67a

fix lint

f4aa364

felipemadero approved these changes Jan 17, 2025

View reviewed changes

sukantoraymond merged commit d9dd3cd into main Jan 17, 2025
37 checks passed

sukantoraymond deleted the local-add-validator branch January 17, 2025 17:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use local machine to join as validator on any L1 #2548

Use local machine to join as validator on any L1 #2548

sukantoraymond commented Jan 10, 2025 •

edited

Loading

meaghanfitzgerald commented Jan 10, 2025

sukantoraymond Jan 14, 2025

sukantoraymond Jan 14, 2025

sukantoraymond commented Jan 17, 2025

felipemadero left a comment

Use local machine to join as validator on any L1 #2548

Use local machine to join as validator on any L1 #2548

Conversation

sukantoraymond commented Jan 10, 2025 • edited Loading

meaghanfitzgerald commented Jan 10, 2025

sukantoraymond Jan 14, 2025

Choose a reason for hiding this comment

sukantoraymond Jan 14, 2025

Choose a reason for hiding this comment

sukantoraymond commented Jan 17, 2025

felipemadero left a comment

Choose a reason for hiding this comment

sukantoraymond commented Jan 10, 2025 •

edited

Loading