Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate pos L1 duration #2455

Merged
merged 2 commits into from
Dec 16, 2024
Merged

validate pos L1 duration #2455

merged 2 commits into from
Dec 16, 2024

Conversation

arturrez
Copy link
Collaborator

Why this should be merged

adds L1 min staking duration for PoS as 24hrs

How this works

How this was tested

How is this documented

@arturrez arturrez requested a review from a team as a code owner December 16, 2024 19:55
Copy link
Collaborator

@felipemadero felipemadero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preapproving with comments

pkg/prompts/validations.go Outdated Show resolved Hide resolved
pkg/prompts/validations.go Show resolved Hide resolved
pkg/prompts/prompts.go Outdated Show resolved Hide resolved
cmd/blockchaincmd/add_validator.go Outdated Show resolved Hide resolved
@arturrez arturrez merged commit 820102d into fix-mainnet Dec 16, 2024
35 checks passed
@arturrez arturrez deleted the validate-l1-duration branch December 16, 2024 21:01
felipemadero added a commit that referenced this pull request Dec 16, 2024
* fix mainnet sa

* nit

* nit

* lint

* update version

* nit

* add a bit more of waiting time for pchain update

* validate pos L1 duration (#2455)

* validate pos L1 duration

* address comments

---------

Co-authored-by: Raymond Sukanto <rsukanto@umich.edu>
Co-authored-by: arturrez <56270896+arturrez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants