add etnaActivationTime #2373
Merged
add etnaActivationTime #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukantoraymond
approved these changes
Nov 25, 2024
| @@ -153,7 +153,11 @@ func NewSignatureAggregator( | |||
| logging.JSON.ConsoleEncoder(), | |||
| ), | |||
| ) | |||
| return initSignatureAggregator(peerNetwork, logger, registerer, subnetID, quorumPercentage) | |||
| etnaTime := time.Unix(0, 0) | |||
There was a problem hiding this comment.
I don't think we should use time.Unix(0,0) at all here
There was a problem hiding this comment.
Since IsZero() returns false for that time. Instead we should just use the default time.Time
There was a problem hiding this comment.
agree. much better way. fixed
Comment on lines
156
to
159
| etnaTime := time.Unix(0, 0) | ||
| if t, ok := constants.EtnaActivationTime[network.ID]; ok { | ||
| etnaTime = t | ||
| } |
There was a problem hiding this comment.
Suggested change
| etnaTime := time.Unix(0, 0) | |
| if t, ok := constants.EtnaActivationTime[network.ID]; ok { | |
| etnaTime = t | |
| } | |
| etnaTime := constants.EtnaActivationTime[network.ID] |
This will use a default (i.e. zero) time.Time instance if the key is not in the map
There was a problem hiding this comment.
totally agree. fixed
…li into etna-activation-map
michaelkaplan13
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
provides correct etna activation time for devnet and fuji
How this works
uses map and default 0,0 value
How this was tested
e2e + regulat etna flow PoA/PoS
How is this documented
n/a