Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuji local clusters #2309
fuji local clusters #2309
Changes from 7 commits
2e8b7e8
8ae71e4
d14c152
b382476
6fda090
a7e68a2
e160b05
2885ec5
44b6dab
0e99b1d
32c85e2
dd4fe9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be cleaner for the caller of
StartLocalNode
to set thenodeConfig
parameter properly for their use case rather than always overriding it with specific settings here. This allows the function to remain more general use for the future, for instance if we want to a start a local node that is going to become a primary network validator.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also only ever serialize the
config
struct to start a node, rather than creating aConfig
instance, serializing it as JSON, then deserializing it to override certain keys, etc. Using the AvalancheGo defined type will be less error prone in the event of any future changes to the config structure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the Start() param to be a map[string]interface{} , and serialize it inside
I believe the avalanchego defined type (if it is the one define under avalanchego/node/config.go)
is not a good fit as we are just trying to set flags for the avalanchego command line, and it seems
not direct to map from the internal Config type to the desired flags. Unless I am missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
ProposerVMUseCurrentHeightKey
required here? I think it shouldn't be necessary with the ACP-151. If it is still required, could you add a comment explaining why?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just included it because it was not included previously and reminded the flag was asked to be set.
Will just not include as I am not pretending it is still required.