Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subnet describe for etna #2238

Closed
wants to merge 2 commits into from
Closed

Fix subnet describe for etna #2238

wants to merge 2 commits into from

Conversation

sukantoraymond
Copy link
Collaborator

@sukantoraymond sukantoraymond commented Oct 11, 2024

Why this should be merged

Fix blockchain describe for etna

How this works

call blockchain describe

How this was tested

call blockchain describe

How is this documented

NA

@sukantoraymond sukantoraymond requested a review from a team as a code owner October 11, 2024 16:42
@sukantoraymond sukantoraymond changed the base branch from main to fix-provide-node-id October 11, 2024 16:42
Base automatically changed from fix-provide-node-id to acp-77 October 11, 2024 16:45
@arturrez
Copy link
Collaborator

this should be reviewed after #2233 as it implements the same thing in a different way

@@ -32,6 +33,8 @@ func (nk NetworkKind) String() string {
return "Local Network"
case Devnet:
return "Devnet"
case Etna:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls wait for #2233 to be merged as this PR implements this in a different way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants