Add support for injecting into an array

[eddycharly]

Would you be ok to support injecting context into an array instead of Psr\Http\Message\RequestInterface ?

It would allow for easier integration into existing code.

Thanks.

[cawolf]

Sure, adding this method could help integrating pre PSR-7 applications. I added some comments to the pull request.

[eddycharly]

Thanks, I will address your comments today.
I wanted to hear back from before getting further.

[eddycharly]

@cawolf it should be ready for review now

[cawolf]

Please see the unresolved conversation regarding the interface.

[eddycharly]

I'm not sure about this in the MockTracer, shouldn't inject preserve the existing headers ?

OpentracingBundle-core/Tests/Mock/MockTracer.php

Lines 50 to 53 in 7e2bc45

	public function inject(SpanContext $spanContext, $format, &$carrier)
	{
	$carrier = ['made_up_header' => '1:2:3:4'];
	}

At least, it is what jukylin/jaeger-php seems to be doing
https://github.com/jukylin/jaeger-php/blob/39b3e83e0fe214692253da5318dffea828d41be5/src/Jaeger/Propagator/JaegerPropagator.php#L23-L30

What do you think ? Should i change the MockTracer implementation ? It would avoid a loop in the injectTracingHeadersIntoCarrier method.

[cawolf]

Sure, you can try to make it work that way. I remember running into issues testing that behaviour exactly because of passing arrays by reference and not be return, that's why that implementation is just pretending to inject headers. After all, it's just here to make the tests work.

[eddycharly]

Preserving existing headers in the MockTracer works as expected and doesn't break any existing test.
I guess a tracer implementation not preserving existing headers should be considered a bug in the tracer itself.

[eddycharly]

@cawolf any chance to get this merged soon ?

[eddycharly]

thanks !

[cawolf]

released in v0.4.2