Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add automatic PR labeler #972

Merged
merged 4 commits into from
May 14, 2024

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Apr 25, 2024

Description

This PR labels PR automatically depending on edited file names.

Following labels should be added:

  • component:control
  • component:localization
  • component:map
  • component:perception
  • component:planning
  • component:sensing
  • component:simulation
  • component:system

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ktro2828 ktro2828 force-pushed the ci/pr-labeler branch 2 times, most recently from e107307 to 9b2b8fa Compare April 25, 2024 06:49
@ktro2828 ktro2828 requested review from xmfcx and mitsudome-r April 25, 2024 07:00
@ktro2828 ktro2828 marked this pull request as ready for review April 25, 2024 07:00
@ktro2828 ktro2828 requested a review from kosuke55 April 25, 2024 09:19
@Owen-Liuyuxuan
Copy link
Contributor

Owen-Liuyuxuan commented Apr 26, 2024

Thanks for the update and contribution.
Personally, I also suggest labels like [RViz] *.rviz file and [Doc] *.md file to make the labeler more complete.

@ktro2828
Copy link
Contributor Author

Thanks for the update and contribution. Personally, I also suggest labels like [RViz] *.rviz file and [Doc] *.md file to make the labeler more complete.

@Owen-Liuyuxuan Thanks for your suggestion. In that cases, what do you think the suitable name of label for *.rviz?

@ktro2828 ktro2828 requested a review from Owen-Liuyuxuan April 26, 2024 01:42
@Owen-Liuyuxuan
Copy link
Contributor

For documents, I suggest following AWF/universe:

https://github.com/autowarefoundation/autoware.universe/blob/main/.github/labeler.yaml

"type:documentation":
  - docs/**/*
  - "**/*.md"
  - "**/*.rst"
  - "**/*.jpg"
  - "**/*.png"
  - "**/*.svg"

For RViz, reference are limited, but I would suggest component:visualization

ktro2828 added 2 commits May 10, 2024 15:25
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828
Copy link
Contributor Author

@Owen-Liuyuxuan Sorry for late reaction. I updated the labeler configuration. Could you check this out? 4e17ef8

If it is OK, I will add new labels.

@xmfcx
Copy link
Contributor

xmfcx commented May 10, 2024

This looks good, once this is done, we need something like https://github.com/lannonbr/issue-label-manager-action on main repositories too. If you have time and you could set it up, I would be very happy.

Until now I've been keeping track of the labels manually in here: https://docs.google.com/spreadsheets/d/1JWQ-PfGamJ_2TO2dM0TV5OQQF1PztpWKIm9O5sI3fQk/edit?usp=sharing

@xmfcx
Copy link
Contributor

xmfcx commented May 10, 2024

For RViz, reference are limited, but I would suggest component:visualization

I would go with component:ui

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828
Copy link
Contributor Author

ktro2828 commented May 13, 2024

For RViz, reference are limited, but I would suggest component:visualization

I would go with component:ui

I've applied component:ui at dea7cd6

Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the udpates and contribution. I do not have further comment.

@ktro2828
Copy link
Contributor Author

ktro2828 commented May 14, 2024

I added new corresponding labels

I will try to set up the label manger action which is suggested by @.xmfcx in the next PR.
https://github.com/lannonbr/issue-label-manager-action

@ktro2828 ktro2828 merged commit 8fb1a7e into autowarefoundation:main May 14, 2024
9 of 10 checks passed
@ktro2828 ktro2828 deleted the ci/pr-labeler branch May 14, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants