Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AEB): add detection range params #934

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Shin-kyoto
Copy link
Contributor

Description

I want to add new parameters corresponding to autowarefoundation/autoware.universe#6637

Tests performed

I checked params in autowarefoundation/autoware.universe#6637

Effects on system behavior

  • When obstacle point clouds appear below the detection_range_min_height, AEB may no longer be able to activate braking.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
@Shin-kyoto Shin-kyoto changed the title Feat/aeb/add params feat(AEB): add params Mar 26, 2024
@takayuki5168 takayuki5168 changed the title feat(AEB): add params feat(AEB): add detection range params Mar 26, 2024
@Shin-kyoto Shin-kyoto requested a review from soblin March 26, 2024 05:50
@Shin-kyoto Shin-kyoto merged commit a6f415d into autowarefoundation:main Mar 26, 2024
10 of 12 checks passed
4swinv pushed a commit to 4swinv/autoware_launch that referenced this pull request Apr 9, 2024
* feat(AEB): add new params for detection_range

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>

* fix(AEB): fix mistake

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>

---------

Signed-off-by: Shin-kyoto <aquashin0202@gmail.com>
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Sep 17, 2024
…e trajectories for v0.46.0 (autowarefoundation#934)

* fix(mpc.param.yaml): fix vehicle_model_steer_tau

Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>

* fix(mpc.param.yaml): fix vehicle_model_steer_tau for id=10 and awsim

Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>

---------

Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants